Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make pre-allocated buffers work again #1901

Draft
wants to merge 6 commits into
base: main
Choose a base branch
from
Draft

Make pre-allocated buffers work again #1901

wants to merge 6 commits into from

Conversation

fifield
Copy link
Collaborator

@fifield fifield commented Nov 2, 2024

  • Fail, don't warn, when bank aware buffer allocation conflicts with buffers with 'address' attribute set.
  • Make basic buffer allocation scheme aware of 'address' attributes
  • Small aiecc update to print errors to user when python bindings are used to run pass pipeline. For example during buffer allocation.

@fifield
Copy link
Collaborator Author

fifield commented Nov 2, 2024

TODO: some tests

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 2, 2024 •
edited
Loading

Coverage Report

Created: 2024-11-05 20:34

Click here for information about interpreting this report.

FilenameFunction CoverageLine CoverageRegion CoverageBranch Coverage
home/runner/work/mlir-aie/mlir-aie/lib/Dialect/AIE/Transforms/AIEAssignBuffers.cpp 95.65% 88.65% 82.98% 75.49%
Totals 95.65% 88.65% 82.98% 75.49%
Generated by llvm-cov -- llvm version 14.0.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@keryell keryell keryell left review comments

@github-actions github-actions[bot] github-actions[bot] left review comments

@AndraBisca AndraBisca Awaiting requested review from AndraBisca AndraBisca will be requested when the pull request is marked ready for review AndraBisca is a code owner

@stephenneuendorffer stephenneuendorffer Awaiting requested review from stephenneuendorffer stephenneuendorffer will be requested when the pull request is marked ready for review stephenneuendorffer is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fifield @keryell